fix(preview): never preview binary files#1591
Open
vegerot wants to merge 1 commit intojunegunn:masterfrom
Open
fix(preview): never preview binary files#1591vegerot wants to merge 1 commit intojunegunn:masterfrom
vegerot wants to merge 1 commit intojunegunn:masterfrom
Conversation
Owner
|
Do you prefer the "After:" output with mime types? I didn't pay much attention to this because I was fine with the error message from bat, or maybe I even preferred it because it clearly showed the |
Owner
|
We could maybe improve the output for binary files |
I think this is a bug fix instead of a new feature. The reason for this is that the current behavior _overrides user choice_ of `FZF_PREVIEW_COMMAND`. No matter what preview command they provide, we never run it on binary files. However, if the user supplies _no_ preview command, then we'll run it through `bat` which produces an error. This sounds like a mistake. This commit makes the behavior when no preview command is supplied the same as the behavior when a preview command is given. Before: <img width="1251" alt="image" src="https://github.com/user-attachments/assets/d5f66828-5a17-439d-bd62-b670e6e9e2e9" /> After: <img width="1232" alt="image" src="https://github.com/user-attachments/assets/dd1d811d-fdc0-4023-8bfa-e97e5b9fdca5" />
Contributor
Author
Good point. Either way the current behavior is inconsistent. I agree with the suggestion in your second message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is a bug fix instead of a new feature. The reason for this is
that the current behavior overrides user choice of
FZF_PREVIEW_COMMAND. Nomatter what preview command they provide, we never run it on binary files.
However, if the user supplies no preview command, then we'll run it through
batwhich produces an error. This sounds like a mistake.This commit makes the behavior when no preview command is supplied the same as
the behavior when a preview command is given.
Before:
After:
