perf: remove session success update api

jumpserver · Oct 23, 2024 · 0f154bd · 0f154bd
1 parent 84a5e30
commit 0f154bd
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/pkg/session/server.go b/pkg/session/server.go
@@ -279,7 +279,6 @@ func (s *Server) Create(ctx *gin.Context, opts ...TunnelOption) (sess TunnelSess
 	}
 	sess.ModelSession = &jmsSession
 	sess.ConnectedCallback = s.RegisterConnectedCallback(jmsSession)
-	sess.ConnectedSuccessCallback = s.RegisterConnectedSuccessCallback(jmsSession)
 	sess.ConnectedFailedCallback = s.RegisterConnectedFailedCallback(jmsSession)
 	sess.DisConnectedCallback = s.RegisterDisConnectedCallback(jmsSession)
 	sess.ReleaseAppletAccount = func() error {

diff --git a/pkg/session/session.go b/pkg/session/session.go
@@ -27,10 +27,9 @@ type TunnelSession struct {
 
 	VirtualAppOpts *model.VirtualAppContainer `json:"-"`
 
-	ConnectedCallback        func() error          `json:"-"`
-	ConnectedSuccessCallback func() error          `json:"-"`
-	ConnectedFailedCallback  func(err error) error `json:"-"`
-	DisConnectedCallback     func() error          `json:"-"`
+	ConnectedCallback       func() error          `json:"-"`
+	ConnectedFailedCallback func(err error) error `json:"-"`
+	DisConnectedCallback    func() error          `json:"-"`
 
 	ReleaseAppletAccount func() error `json:"-"`
 

diff --git a/pkg/tunnel/server.go b/pkg/tunnel/server.go
@@ -211,9 +211,7 @@ func (g *GuacamoleTunnelServer) Connect(ctx *gin.Context) {
 	}
 	defer tunnel.Close()
 	g.RecordLifecycleLog(sessionId, model.AssetConnectSuccess, model.EmptyLifecycleLog)
-	if err1 := tunnelSession.ConnectedSuccessCallback(); err1 != nil {
-		logger.Errorf("Update session connect status failed %+v", err1)
-	}
+
 	logger.Infof("Session[%s] use resolution (%d*%d)",
 		sessionId, info.OptimalScreenWidth, info.OptimalScreenHeight)
 	meta := MetaShareUserMessage{