perf: add warning msg for acl_face_verify #1611
Conversation
| msg := lang.T("Face verification is not supported yet. Please use the WebTerminal to connect the asset.") | ||
| utils.IgnoreErrWriteString(u.h.term, msg) | ||
| utils.IgnoreErrWriteString(u.h.term, utils.CharNewLine) | ||
| return | ||
| case model.ACLReview: | ||
| reviewHandler := LoginReviewHandler{ | ||
| readWriter: u.h.sess, |
There was a problem hiding this comment.
None found.
Regarding knowledge cutoff, we're currently at February 28th of the year 2024 so there should be no such problems.
| msg := lang.T("Face verification is not supported yet. Please use the WebTerminal to connect the asset.") | ||
| utils.IgnoreErrWriteString(d.term, msg) | ||
| utils.IgnoreErrWriteString(d.term, utils.CharNewLine) | ||
| return | ||
| case model.ACLReview: | ||
| reviewHandler := LoginReviewHandler{ | ||
| readWriter: d.wrapperSess, |
There was a problem hiding this comment.
In the given source code snippet, some key lines that may indicate potential issues include the use of "utils.IgnoreErrWriteString" which seems incorrect because error handling using this function often involves logging rather than writing strings back out.
It is recommended to review these specific functions:
-
ignoreError()and their implementations should correctly log errors instead of simply ignoring them. -
Check whether
ignoreErroris part of or imported from necessary packages likelogfor proper context and functionality. It could be causing unnecessary overhead if it's used with other non-standard functions that don't need such logging behavior.
Additionally, I noticed that there might possibly be a syntax/mistake on line 446 in the case structure. The keyword was incorrectly mentioned twice as an argument. Here's the corrected version assuming the intention behind the keywords were correct:
case model.ACLReview:
// todo: Reviewing the content and asking users for feedback...
logger.Errorf("Failed to create connect token and auth information after reviewing: %s %s", tokenInfo.Code, tokenInfo.Detail)
msg := fmt.Sprintf(lang.T("Reviewing asset content..."), asset.PermStr())
utils.WriteStringToConsole(d.term, msg)
return
If the purpose of checking the review status against different statuses wasn’t intended, the logic should be adjusted accordingly within the respective cases. This ensures clarity, precision, and avoids unexpected behaviors during debug analysis.
| @@ -69,6 +69,8 @@ type ConnectTokenInfo struct { | |||
| const ( | |||
| ACLReview = "acl_review" | |||
| ACLReject = "acl_reject" | |||
|
|
|||
| ACLFaceVerify = "acl_face_verify" | |||
| ) | |||
|
|
|||
| type ConnectOptions struct { | |||
There was a problem hiding this comment.
The code seems to be correct and contains no apparent irregularities, issues or optimizations needed at this moment.
|
perf: add warning msg for acl_face_verify