[breaking] pass factory to Optimizer instead of ::MOI.ModelLike#68
Open
odow wants to merge 2 commits into
Open
[breaking] pass factory to Optimizer instead of ::MOI.ModelLike#68odow wants to merge 2 commits into
odow wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 548 548
=========================================
Hits 548 548 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
blegat
requested changes
May 25, 2026
Member
blegat
left a comment
blegat
left a comment
There was a problem hiding this comment.
This goes the opposite direction of jump-dev/Dualization.jl#209. I think layer should take instantiated model, it's too hard for a layer to know how to instantiate a factory, see jump-dev/MathOptInterface.jl#2986
Member
Author
|
Passing instantiated optimisers is more complicated from a user perspective. Let's chat about this at JuMP-dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.