feat(seo): Tier C identity migration + ProfilePage schema #400
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| // src/lib/schema/profile-page.ts | ||
| // | ||
| // Generates ProfilePage schema for /about — the canonical author-entity page. | ||
| // ProfilePage embeds the Person schema as mainEntity. Google + AI citation | ||
| // pipelines use this combo as the authoritative author-identity declaration. | ||
| // | ||
| // Usage: import { generateProfilePageSchema } from '@/lib/schema'; emit via | ||
| // <SchemaScript schema={[generateProfilePageSchema(), ...]} />. | ||
|
|
||
| import { AUTHOR_CONFIG, SITE_CONFIG } from "./config"; | ||
| import type { ProfilePageSchema } from "./types"; | ||
|
|
||
| export function generateProfilePageSchema(): ProfilePageSchema { | ||
| return { | ||
| "@context": "https://schema.org", | ||
| "@type": "ProfilePage", | ||
| "@id": `${SITE_CONFIG.url}/about#profile-page`, | ||
| url: `${SITE_CONFIG.url}/about`, | ||
| name: `About ${AUTHOR_CONFIG.name} — ${SITE_CONFIG.name}`, | ||
| isPartOf: { "@id": SITE_CONFIG.websiteId }, | ||
| // Embedded Person mainEntity intentionally omits @context — it lives on | ||
| // the top-level ProfilePage only, matching Google's documented example. | ||
| mainEntity: { | ||
| "@type": "Person", | ||
| "@id": AUTHOR_CONFIG.id, | ||
| name: AUTHOR_CONFIG.name, | ||
| alternateName: AUTHOR_CONFIG.alternateName, | ||
| url: AUTHOR_CONFIG.url, | ||
| sameAs: [...AUTHOR_CONFIG.sameAs], | ||
| description: AUTHOR_CONFIG.description, | ||
| jobTitle: AUTHOR_CONFIG.jobTitle, | ||
| knowsAbout: [...AUTHOR_CONFIG.knowsAbout], | ||
| }, | ||
|
Collaborator
There was a problem hiding this comment. SUGGESTION —
Collaborator
There was a problem hiding this comment. SUGGESTION — DRY: the embedded The type system catches a missing required field on A small refactor folds them together: export function generateProfilePageSchema(): ProfilePageSchema {
// Reuse the standalone Person body; `@context` is owned by the top-level ProfilePage.
const { "@context": _ctx, ...person } = generatePersonSchema();
return {
"@context": "https://schema.org",
"@type": "ProfilePage",
"@id": `${SITE_CONFIG.url}/about#profile-page`,
url: `${SITE_CONFIG.url}/about`,
name: `About ${AUTHOR_CONFIG.name} — ${SITE_CONFIG.name}`,
isPartOf: { "@id": SITE_CONFIG.websiteId },
mainEntity: person,
};
}Non-blocking — every emitted field is correct today, and the two existing sites stay in sync as long as |
||
| }; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| import { describe, it, expect, vi } from "vitest"; | ||
|
|
||
| // Mock the schema config module to avoid the NEXT_PUBLIC_SERVER_URL env check | ||
| // that fires at import time in src/lib/site-url.ts. Mocks reflect post-Tier-C | ||
| // AUTHOR_CONFIG shape (real name + jobTitle + knowsAbout). | ||
| vi.mock("@/lib/schema/config", () => ({ | ||
| SITE_CONFIG: { | ||
| url: "https://detached-node.com", | ||
| name: "detached-node", | ||
| description: "Test description", | ||
| websiteId: "https://detached-node.com/#website", | ||
| }, | ||
| AUTHOR_CONFIG: { | ||
| name: "Julian Kennon", | ||
| alternateName: "detached-node", | ||
| url: "https://detached-node.com/about", | ||
| id: "https://detached-node.com/#author", | ||
| sameAs: [ | ||
| "https://github.com/julianken", | ||
| "https://www.linkedin.com/in/julian-kennon", | ||
| ], | ||
| description: "Software engineer focused on agentic AI workflows.", | ||
| jobTitle: "Software Engineer", | ||
| knowsAbout: [ | ||
| "Agentic AI design patterns", | ||
| "Distributed systems", | ||
| "TypeScript", | ||
| ], | ||
| }, | ||
| })); | ||
|
|
||
| import { generateProfilePageSchema } from "@/lib/schema/profile-page"; | ||
| import { SITE_CONFIG, AUTHOR_CONFIG } from "@/lib/schema/config"; | ||
|
|
||
| // --------------------------------------------------------------------------- | ||
| // generateProfilePageSchema | ||
| // --------------------------------------------------------------------------- | ||
|
|
||
| describe("generateProfilePageSchema", () => { | ||
| it("returns top-level @context and @type ProfilePage", () => { | ||
| const schema = generateProfilePageSchema(); | ||
| expect(schema["@context"]).toBe("https://schema.org"); | ||
| expect(schema["@type"]).toBe("ProfilePage"); | ||
| }); | ||
|
|
||
| it("@id is the canonical ProfilePage identifier (about#profile-page)", () => { | ||
| const schema = generateProfilePageSchema(); | ||
| expect(schema["@id"]).toBe(`${SITE_CONFIG.url}/about#profile-page`); | ||
| }); | ||
|
|
||
| it("url points at /about", () => { | ||
| const schema = generateProfilePageSchema(); | ||
| expect(schema.url).toBe(`${SITE_CONFIG.url}/about`); | ||
| }); | ||
|
|
||
| it("name embeds author display name and site name", () => { | ||
| const schema = generateProfilePageSchema(); | ||
| expect(schema.name).toBe( | ||
| `About ${AUTHOR_CONFIG.name} — ${SITE_CONFIG.name}` | ||
| ); | ||
| }); | ||
|
|
||
| it("isPartOf links to the canonical WebSite via @id", () => { | ||
| const schema = generateProfilePageSchema(); | ||
| expect(schema.isPartOf).toEqual({ "@id": SITE_CONFIG.websiteId }); | ||
| }); | ||
|
|
||
| it("embeds Person as mainEntity with @type and @id, but NOT @context (matches Google's example)", () => { | ||
| const schema = generateProfilePageSchema(); | ||
| expect(schema.mainEntity["@type"]).toBe("Person"); | ||
| expect(schema.mainEntity["@id"]).toBe(AUTHOR_CONFIG.id); | ||
| // Embedded Person must not carry @context — it lives on the top-level | ||
| // ProfilePage only. | ||
| expect("@context" in schema.mainEntity).toBe(false); | ||
| }); | ||
|
|
||
| it("mainEntity.name matches AUTHOR_CONFIG.name (real name, not pseudonym)", () => { | ||
| const schema = generateProfilePageSchema(); | ||
| expect(schema.mainEntity.name).toBe(AUTHOR_CONFIG.name); | ||
| expect(schema.mainEntity.name).toBe("Julian Kennon"); | ||
| }); | ||
|
|
||
| it("mainEntity.alternateName is the brand alias 'detached-node'", () => { | ||
| const schema = generateProfilePageSchema(); | ||
| expect(schema.mainEntity.alternateName).toBe(AUTHOR_CONFIG.alternateName); | ||
| expect(schema.mainEntity.alternateName).toBe("detached-node"); | ||
| }); | ||
|
|
||
| it("mainEntity.url points at /about (canonical author page)", () => { | ||
| const schema = generateProfilePageSchema(); | ||
| expect(schema.mainEntity.url).toBe(AUTHOR_CONFIG.url); | ||
| }); | ||
|
|
||
| it("mainEntity.sameAs is a fresh array, not the same reference as AUTHOR_CONFIG.sameAs", () => { | ||
| const schema = generateProfilePageSchema(); | ||
| expect(schema.mainEntity.sameAs).toEqual([...AUTHOR_CONFIG.sameAs]); | ||
| // Mutation of the schema array must not affect the const config array. | ||
| expect(schema.mainEntity.sameAs).not.toBe(AUTHOR_CONFIG.sameAs); | ||
| }); | ||
|
|
||
| it("mainEntity carries description, jobTitle, knowsAbout from config", () => { | ||
| const schema = generateProfilePageSchema(); | ||
| expect(schema.mainEntity.description).toBe(AUTHOR_CONFIG.description); | ||
| expect(schema.mainEntity.jobTitle).toBe(AUTHOR_CONFIG.jobTitle); | ||
| expect(schema.mainEntity.knowsAbout).toEqual([...AUTHOR_CONFIG.knowsAbout]); | ||
| }); | ||
|
|
||
| it("mainEntity.knowsAbout is a fresh array, not the same reference as AUTHOR_CONFIG.knowsAbout", () => { | ||
| const schema = generateProfilePageSchema(); | ||
| expect(schema.mainEntity.knowsAbout).not.toBe(AUTHOR_CONFIG.knowsAbout); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SUGGESTION — File-header comment is stale.
This PR correctly updates the in-block comment here ("Tier C identity migration: real name in schema..."), but the file-header block at lines 5-13 (unchanged, outside diff) still reads:
That framing describes a pre-migration state that no longer exists — name is now
"Julian Kennon", sameAs has the LinkedIn entry, description is the expanded biography. A future maintainer reading the top of this file will think the migration is still pending.Suggested rewrite: shorten the header to a one-line summary of the current state ("Author entity config — real name in JSON-LD; brand-only as
siteName") and drop the migration checklist. Pure doc-rot cleanup.