build(deps): bump the actions-core group across 1 directory with 2 updates#304
Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
…dates Bumps the actions-core group with 2 updates in the / directory: [actions/checkout](https://github.com/actions/checkout) and [actions/setup-node](https://github.com/actions/setup-node). Updates `actions/checkout` from 4 to 6 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v6) Updates `actions/setup-node` from 4 to 6 - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v4...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-core - dependency-name: actions/setup-node dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-core ... Signed-off-by: dependabot[bot] <support@github.com>
24dc6b3 to
b0246ab
Compare
julianken-bot
left a comment
There was a problem hiding this comment.
Verdict: APPROVE — Two-file v4→v6 bump to actions/checkout + actions/setup-node, completing alignment with the eight workflows already on v6. R1/R2 verification confirms the v6 persisted-credentials path change does not bite this repo: no Docker container actions present.
What I verified (this turn)
git grep -n "actions/checkout\|actions/setup-node" pr-304-review -- .github/workflows/→ all 10 workflows on@v6post-merge; nov4stragglers remaingrep -rn "container:" .github/workflows/→ 0 matches; no Docker container actions consume the previously-persisted creds (the v6 release-notes risk surface)grep -rn "runs-on:" .github/workflows/→ all 12 jobs onubuntu-latest(GitHub-hosted, runner ≥ v2.334 > the v2.329 v6 minimum)python3 -c "import json,sys;p=json.load(sys.stdin);print(p.get(\"packageManager\"))" < package.json→None, so the setup-node v5/v6 automatic-caching breaking change (limited to npm in v6) does not apply; explicitcache: pnpminput remains supported in v6 peractions/setup-nodeaction.ymlonmaingh pr checks 304→ 12/12 required checks pass on the head SHA (ESLint, TypeScript, Vitest, Next.js Build, Analyze Bundle, CodeQL, E2E shards 1–4)
Findings (0)
None. Mandatory second-pass read surfaced no real issues. Pre-existing patterns I considered but did not flag (R7): pnpm version: 9 is unpinned to a minor, and actions are pinned by major rather than commit SHA — both predate this PR and apply uniformly across all nine pnpm/action-setup invocations and the eight already-v6 workflow refs.
Bottom line: ready to merge.
Reviewer: @julianken-bot (opus) — fresh-context subagent dispatched via the reviewing-as-julianken-bot skill. Verdict above is binding regardless of GitHub's review label.
|
@Mergifyio queue |
Merge Queue Status
This pull request spent 14 minutes 6 seconds in the queue, including 2 minutes 58 seconds running CI. Required conditions to merge
|
Bumps the actions-core group with 2 updates in the / directory: actions/checkout and actions/setup-node.
Updates
actions/checkoutfrom 4 to 6Release notes
Sourced from actions/checkout's releases.
... (truncated)
Changelog
Sourced from actions/checkout's changelog.
... (truncated)
Commits
de0fac2Fix tag handling: preserve annotations and explicit fetch-tags (#2356)064fe7fAdd orchestration_id to git user-agent when ACTIONS_ORCHESTRATION_ID is set (...8e8c483Clarify v6 README (#2328)033fa0dAdd worktree support for persist-credentials includeIf (#2327)c2d88d3Update all references from v5 and v4 to v6 (#2314)1af3b93update readme/changelog for v6 (#2311)71cf226v6-beta (#2298)069c695Persist creds to a separate file (#2286)ff7abcdUpdate README to include Node.js 24 support details and requirements (#2248)08c6903Prepare v5.0.0 release (#2238)Updates
actions/setup-nodefrom 4 to 6Release notes
Sourced from actions/setup-node's releases.
... (truncated)
Commits
48b55a0Update Node.js versions in versions.yml and bump package to v6.4.0 (#1533)ab72c7eUpgrade@actionsdependencies (#1525)53b8394Bump minimatch from 3.1.2 to 3.1.5 (#1498)54045abScope test lockfiles by package manager and update cache tests (#1495)c882bffReplace uuid with crypto.randomUUID() (#1378)774c1d6feat(node-version-file): support parsingdevEnginesfield (#1283)efcb663fix: remove hardcoded bearer (#1467)d02c89dFix npm audit issues (#1491)6044e13Docs: bump actions/checkout from v5 to v6 (#1468)8e49463Fix README typo (#1226)