Donot override cache atime when scanning from local disk #5692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Changxin Miao <[email protected]>
| cache.keys[k] = cacheItem{it.size, uint32(time.Now().Unix())} | ||
| } else { | ||
| cache.keys[k] = cacheItem{int32(size), uint32(time.Now().Unix())} |
There was a problem hiding this comment.
cache file maybe removed in cleanupExpire after open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scanning from disk overwrites
sizeandatimeof existing cache items in memory:sizeis overwritten by the physical size of the file, which includes the logical size plus the CRC footer. However, when adding cache in other places, we use the logical size. I suppose it's better to be consistent on which size to use.The granularity of file system's
atimeis relatively coarse (relatime), and some even have atime disabled (noatime). However,atimerecorded in memory has finer granularity and is more accurate in most cases. Overwritingatimein memory blindly would cause the expire eviction strategy not working as expected.