Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3, allow app_name in Growl notifications #13

Merged
merged 2 commits into from
Mar 26, 2013
Merged

Fix #3, allow app_name in Growl notifications #13

merged 2 commits into from
Mar 26, 2013

Conversation

kristianfreeman
Copy link
Contributor

This PR fixes #3 and allows the inclusion of an app_name from ruby-growl and ruby_gntp.

The syntax is a simple passing in of an option:

Notify.notify "Title", "Message", { app_name: "My App" }

I've also updated the README as well.

@mattn
Copy link
Collaborator

mattn commented Mar 26, 2013

@jugyo this idea is good to fix #10 with add more some configurables.

@jugyo
Copy link
Owner

jugyo commented Mar 26, 2013

looks gooood 👍

jugyo pushed a commit that referenced this pull request Mar 26, 2013
Fix #3, allow app_name in Growl notifications
@jugyo jugyo merged commit ac4788f into jugyo:master Mar 26, 2013
@kristianfreeman kristianfreeman deleted the 3-allow-app-name-in-growl branch March 26, 2013 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Growl の場合は appname 等を指定できないとやっぱり不便
3 participants