-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop global refactoring #105
Open
judithabk6
wants to merge
86
commits into
main
Choose a base branch
from
develop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 80 commits
Commits
Show all changes
86 commits
Select commit
Hold shift + click to select a range
8530e26
Input check (#81)
judithabk6 e062cbd
Modularized estimators
brash6 ea38355
nuisances functions
brash6 6d78313
some new constants
brash6 124873e
some new utils functions
brash6 84c185d
useful decorators
brash6 b13147e
useful estimator loader to be uysed in the future
brash6 5e88fc1
still messy nuisances.py file
brash6 3e4a995
some scoring functions
brash6 f100116
experiment file to try estimators (to be enhanced)
brash6 90b7184
remove unused class variables
brash6 c828524
enhance base file
brash6 5bc00b4
rename experiment.y into example.py file
brash6 81263ee
apply refactoring PR comments
brash6 632a094
minor reformat example file
brash6 8927181
get rid of _get_interactions in base and add _input_reshape function
brash6 9ad7c0a
application of modifications
brash6 48fb5ed
remove cross fitting
brash6 d35f7d2
minor changes in coefficient product
brash6 ab8207a
remove discrete procedure in g computation
brash6 f2ed579
minor changes in ipw
brash6 09936d4
minor changes in ipw
brash6 9c36a8a
Revert "minor changes in ipw"
brash6 118a8c3
clean dml
brash6 c14ef7a
clean dml correct
brash6 4645318
not clean multiply robust
brash6 8140f40
clean multiply robust
brash6 8f783d4
remove useless loader file
brash6 c7b1e1f
old example
brash6 a743d74
new example
brash6 8ac63aa
fix reshape in coefficient product
brash6 3ffc4c0
remove _fit_nuisances and _score functions
brash6 e9475ca
fix predict_proba results reshape
brash6 43c8c51
default trim value for mediation DML
brash6 163fab5
remove trimming in DML
brash6 df342d2
minor bug fix in MR
brash6 cc6dfb1
working examples with comparions to med_bench
brash6 b23426c
remove unrelevant crossfitting in docstrings
brash6 b74bd36
intercept instead of m1
brash6 8da1d74
line formatting
houssamzenati 435ed25
line formatting
houssamzenati cf8af6d
line formatting
houssamzenati d022006
line formatting changes
houssamzenati 6378d43
line formatting
houssamzenati ae48827
remove comments, main module
houssamzenati 6e59dd0
partial tests of new modularized estimators
houssamzenati f6ede7a
partial tests of new modularized estimators
houssamzenati cef6b32
rename ipw
brash6 817abec
regressor and classifier now child class variables
brash6 47a3723
Fixed GComputation
brash6 3650467
Merge remote-tracking branch 'refs/remotes/origin/refactoring' into r…
brash6 192ea20
tests refactor
brash6 b29becf
remove reg from IPW
brash6 046e977
clean dml docstrings
brash6 9da25c0
get rid of estimators using cross fitting
brash6 ac77369
fix tests
brash6 825bb12
tests refactored
brash6 9bff44b
files cleaning
brash6 b344910
fix tests
brash6 cd93d77
started to remove R dependencies
6290ddb
rename methods, clean inputs
judithabk6 a95e610
tmle testing, exactness tests
houssamzenati 2789d63
tmle testing, exactness tests
houssamzenati e4f124f
tmle testing, exactness tests
houssamzenati 6cc1b66
explanations and docstrings TMLE, line formatting
houssamzenati 13c591f
refactor tests (remove old config parameter and have better names fo…
judithabk6 80f4fa0
remove unused options in get_estimation_results
judithabk6 bc21e83
direct effect treated, indirect effect control fixes
houssamzenati ce48988
removed exactness tests, fixed TMLE outputs for tolerance tests
houssamzenati 5a77e67
slight change in test formatting
judithabk6 005fb21
remove unused file for the tests
judithabk6 566a08c
Update src/med_bench/estimation/base.py
bthirion b22d50f
Update src/tests/estimation/test_get_estimation.py
bthirion dce928d
Update src/med_bench/estimation/base.py
bthirion dfc0cc0
Update src/med_bench/estimation/base.py
bthirion b4a26a9
Update src/med_bench/estimation/base.py
bthirion 08a997d
Merge pull request #92 from judithabk6/refactoring
judithabk6 ab36036
add doc files
brash6 b93cf22
make doc build
judithabk6 c7a9d3c
Merge branch 'main' into develop
judithabk6 064dd29
fix bug in tests
judithabk6 bbc6749
unused file
judithabk6 48e3224
remove utils module from API doc as it is internal
judithabk6 54a0a6c
remove unused code
judithabk6 2bc2944
fix absence of return self in DML estimator
judithabk6 c479ee9
fix indentation
judithabk6 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,6 +39,8 @@ jobs: | |
dependencies: 'NA' | ||
install-pandoc: false | ||
packages: | | ||
[email protected] | ||
[email protected] | ||
grf | ||
causalweight | ||
mediation | ||
|
@@ -53,6 +55,7 @@ jobs: | |
|
||
- name: Run tests with coverage | ||
run: | | ||
export LD_LIBRARY_PATH=$(python -m rpy2.situation LD_LIBRARY_PATH):${LD_LIBRARY_PATH} | ||
pytest --cov=med_bench --cov-report=xml | ||
|
||
- name: Upload coverage to Codecov | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,6 +39,8 @@ jobs: | |
dependencies: 'NA' | ||
install-pandoc: false | ||
packages: | | ||
[email protected] | ||
[email protected] | ||
grf | ||
causalweight | ||
mediation | ||
|
@@ -53,4 +55,5 @@ jobs: | |
|
||
- name: Run tests | ||
run: | | ||
pytest | ||
export LD_LIBRARY_PATH=$(python -m rpy2.situation LD_LIBRARY_PATH):${LD_LIBRARY_PATH} | ||
pytest |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,57 +1,68 @@ | ||
.. toctree:: | ||
:maxdepth: 4 | ||
:caption: Contents: | ||
:caption: API: | ||
|
||
|
||
med_bench | ||
================= | ||
.. automodule:: med_bench | ||
:members: | ||
:undoc-members: | ||
:show-inheritance: | ||
|
||
|
||
get_estimation | ||
-------- | ||
|
||
.. automodule:: med_bench.get_estimation | ||
|
||
Estimation | ||
========== | ||
.. automodule:: med_bench.estimation | ||
:members: | ||
:undoc-members: | ||
:show-inheritance: | ||
|
||
|
||
get_simulated_data | ||
-------- | ||
.. automodule:: med_bench.estimation.mediation_coefficient_product | ||
:members: | ||
:undoc-members: | ||
|
||
.. automodule:: med_bench.get_simulated_data | ||
|
||
.. automodule:: med_bench.estimation.mediation_g_computation | ||
:members: | ||
:undoc-members: | ||
:show-inheritance: | ||
|
||
.. automodule:: med_bench.estimation.mediation_ipw | ||
:members: | ||
:undoc-members: | ||
|
||
mediation | ||
-------- | ||
|
||
.. automodule:: med_bench.mediation | ||
.. automodule:: med_bench.estimation.mediation_mr | ||
:members: | ||
:undoc-members: | ||
:show-inheritance: | ||
|
||
|
||
utils | ||
-------- | ||
.. automodule:: med_bench.estimation.mediation_dml | ||
:members: | ||
:undoc-members: | ||
|
||
.. automodule:: med_bench.utils.utils | ||
|
||
|
||
.. automodule:: med_bench.estimation.mediation_tmle | ||
:members: | ||
:undoc-members: | ||
|
||
|
||
|
||
get_simulated_data | ||
========== | ||
|
||
.. automodule:: med_bench.get_simulated_data | ||
:members: | ||
:undoc-members: | ||
:show-inheritance: | ||
|
||
|
||
nuisances | ||
-------- | ||
utils | ||
========== | ||
|
||
.. automodule:: med_bench.utils.nuisances | ||
.. automodule:: med_bench.utils.utils | ||
:members: | ||
:undoc-members: | ||
:show-inheritance: | ||
|
||
|
||
|
||
|
Binary file not shown.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure it is interesting to do a documentation about the utils module ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be happy to check some internal functions as a user. Here it is just to display the parameters the function takes etc, but ok... We will see in the doc refactor