fix: fix logic for resolving path to themes#578
Open
notslang wants to merge 1 commit intojsonresume:masterfrom
Open
fix: fix logic for resolving path to themes#578notslang wants to merge 1 commit intojsonresume:masterfrom
notslang wants to merge 1 commit intojsonresume:masterfrom
Conversation
notslang
commented
May 12, 2021
| let resolvedPath; | ||
| if (themePath[0] === '.') { | ||
| path = tryResolve(path.join(cwd, themePath), { paths: [cwd] }); | ||
| throw new Error( |
Author
There was a problem hiding this comment.
I don't really know why there was a throw here. It seems like it would always fail for a path that begins with a dot. I removed that to make it work.
notslang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting errors when specifying a path to a theme that begins with a dot because
path.joinwasn't a function. I renamed the existingpathvar toresolvedPathand imported the path module thatpath.joincomes from.