Add name jump mark to renderer options & update section links to it #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that what's currently online on http://jsonapi-rb.org/guides/serialization/rendering.html with only having the rendering options doesn't seem to match what's in source/. Your new automatic deployment commits on master from some hours ago have put most content in the getting started section. With these changes also reflected in the source branch, this PR here wouldn't make sense, as only the rendering options section would be there. But the rendering page seems a bit out of context like that (the way it's currently online). |
|
Hi @aCandidMind – thanks for pointing this out! I made the changes and the deploy in a branch and forgot to merge it into source. It should be in sync now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #20 which applies to the actually used
sourcebranch.Tested this by checking with
middleman buildandrackup.