Build a JUnit 5 Extension for the Snapshotmatcher Library #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds into SnapshotUtils Moving state into ExecutionContext. Extracting config values from Jvm/ExecutionContext Adding unit tests
|
Any progress on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in a Junit5 Extension to easily use this great library when using JUnit5. The Extension
@ExtendWith(SnapshotMatcherExtension.class)can be added at the class or individual test level. Once added, the SnapshotMatcher framework is initialized before each test and validated after each test runs.It tries to takes advantage of JUnits Extension framework wherever possible. For instance, local state is now stored inside of the
ExtensionContextwhich is local to each executed test. Also, config values can now be supplied as System properties and pulled out of theExtensionContext(i.e. directory for snaps). Finally it adds support forParameterizedtest and their dynamic test names.