Skip to content

Migrate Tag, Badge, and Remember Components to ShadCN and Add Tests #1689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 14, 2025

Conversation

idanidan29
Copy link
Collaborator

@idanidan29 idanidan29 commented Jun 6, 2025

What kind of change does this PR introduce?

  • Adapted 3 components to use the ShadCN library.
  • Created and adjusted Cypress test files for these 3 components and for the shadCN card element to ensure reliability and behavior coverage.
  • While adapting the components, utilized ShadCN's Card and Badge elements.

Issue Number:

Screenshots/videos:

  • tag component before adjustment:
    image

  • tag component after adjustment:
    image

The tag and badge components looks exactly the same after migration to ShadCN.

Summary

This PR:

  • Migrated the existing tag.tsx, badge.tsx, and remember.tsx components to the ShadCN library.
  • Enhanced the styling of the tag component to improve dark mode compatibility (open to feedback).
  • Added and adjusted Cypress tests for all implemented components to ensure reliability and behavior coverage.
  • Some of the files ended up with more lines of code, but the result is more maintainable and easier to configure.

Does this PR introduce a breaking change?

no

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@idanidan29 idanidan29 requested a review from a team as a code owner June 6, 2025 12:40
Copy link

github-actions bot commented Jun 6, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview ab5ec5c

Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (169a524) to head (ab5ec5c).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1689   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        14    +4     
  Lines          396       434   +38     
  Branches       106       116   +10     
=========================================
+ Hits           396       434   +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot requested a deployment to Preview June 6, 2025 13:37 Abandoned
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjagm benjagm merged commit 4f081ac into json-schema-org:main Jun 14, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from Ready to review to Done in PR - Triage Group Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants