Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark AddOpenApiForJsonApi with [Experimental] #1663

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

bkoelman
Copy link
Member

@bkoelman bkoelman commented Jan 3, 2025

Adds [Experimental] to the AddOpenApiForJsonApi extension method and adds a warning to the docs.
Replaces our own UnreachableCodeException with the built-in System.Diagnostics.UnreachableException.

QUALITY CHECKLIST

@bkoelman bkoelman marked this pull request as ready for review January 3, 2025 10:45
@bkoelman bkoelman merged commit d196e12 into openapi Jan 3, 2025
14 checks passed
@bkoelman bkoelman deleted the openapi-mark-experimental branch January 3, 2025 10:46
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (d81abed) to head (55faea6).
Report is 3 commits behind head on openapi.

Additional details and impacted files
@@       Coverage Diff       @@
##   openapi   #1663   +/-   ##
===============================
===============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant