Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

face_detector is released, so remove .travis.rosinstall.noetic . add test to check with latest pyyaml from pip #884

Merged
merged 2 commits into from
Jan 20, 2024
Merged

face_detector is released, so remove .travis.rosinstall.noetic . add test to check with latest pyyaml from pip #884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0856a7
face_detector is released, so remove .travis.rosinstall.noetic . add …
k-okada Jan 19, 2024
1a98ce8
[jsk_rqt_plugins] Fix yaml load in tabbed_button_general.py
Kanazawanaoaki Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ jobs:
CONTAINER: ubuntu:18.04
- ROS_DISTRO: noetic
CONTAINER: ubuntu:20.04
USE_DEB : false # to use .travis.rosinstall.noetic for face_detector
- ROS_DISTRO: noetic
CONTAINER: ubuntu:20.04
BEFORE_SCRIPT: "pip3 install -U --user pyyaml"

container: ${{ matrix.CONTAINER }}
steps:
Expand Down
3 changes: 0 additions & 3 deletions .travis.rosinstall.noetic
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion jsk_rqt_plugins/src/jsk_rqt_plugins/tabbed_button_general.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ def __init__(self, settings):
resolved_yaml = resolved_yaml[len("file://"):]

with open(resolved_yaml) as f:
yaml_data = yaml.load(f)
yaml_data = yaml.safe_load(f)
self.setupButtons_with_yaml_data(yaml_data=yaml_data, namespace=namespace)

self.show()
Loading