-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jsk_perception] Add Visual Grounding with GroundingDINO #2796
base: master
Are you sure you want to change the base?
[jsk_perception] Add Visual Grounding with GroundingDINO #2796
Conversation
I'll review it on Saturday |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think creating this new msg (ClassificationResult + RectArray) is necessary? There were so many cases of returning detected objects' rect array.
To see jsk-ros-pkg/coral_usb_ros, it publishes RectArray
and ClassificationResult
at same time.
I want some opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply.
I see. I guess I thought it would be convenient to have one message at the time, but I will change it so that RectArray
and ClassificationResult
can be sent out at the same time and synchronized when they are used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for late. I left single comment, but overall lgtm |
This PR enables visual grounding using GroundingDINO.
How to use
After build the Image with bellow
You need to specify the port, etc. according to the situation, but you can launch docker as follows
Launch the ros node as follows