Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #include <boost/format.hpp> #1584

Merged

Conversation

lalten
Copy link
Contributor

@lalten lalten commented Jun 20, 2018

When building jsk_topic_tools on Ubuntu 18.04 with Ros Melodic and Boost 1.65.1.0ubuntu1 I get this error:

Starting  >>> jsk_topic_tools                                                                            
________________________________________________________________________________________________________ 
Errors     << jsk_topic_tools:make /home/laurenz/catkin_ws/logs/jsk_topic_tools/build.make.001.log       
/home/laurenz/catkin_ws/src/jsk/jsk_common/jsk_topic_tools/src/standalone_complexed_nodelet.cpp: In funct
ion ‘int main(int, char**)’:                                                                             
/home/laurenz/catkin_ws/src/jsk/jsk_common/jsk_topic_tools/src/standalone_complexed_nodelet.cpp:75:38: er
ror: ‘format’ is not a member of ‘boost’                                                                 
     candidate_root.push_back((boost::format("nodelets_%lu") % i).str());                                
                                      ^~~~~~                                                             
/home/laurenz/catkin_ws/src/jsk/jsk_common/jsk_topic_tools/src/standalone_complexed_nodelet.cpp:75:38: no
te: suggested alternative: ‘forward’                                                                     
     candidate_root.push_back((boost::format("nodelets_%lu") % i).str());                                
                                      ^~~~~~                                                             
                                      forward                                                            
make[2]: *** [CMakeFiles/standalone_complexed_nodelet.dir/src/standalone_complexed_nodelet.cpp.o] Error 1
make[1]: *** [CMakeFiles/standalone_complexed_nodelet.dir/all] Error 2                                   
make[1]: *** Waiting for unfinished jobs....                                                             
make: *** [all] Error 2                                                                                  

which is easily fixed by including the appropriate include.
Apparently it wasn't needed with boost 1.62: wisk/medusa#65

@k-okada k-okada merged commit dae9c2e into jsk-ros-pkg:master Jun 20, 2018
@k-okada
Copy link
Member

k-okada commented Jun 20, 2018

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants