Skip to content

Add HTTP_PROXY during build + fix 2 bugs in fibers and minifer modules#113

Open
korenlev wants to merge 5 commits intojshimko:masterfrom
korenlev:patch-1
Open

Add HTTP_PROXY during build + fix 2 bugs in fibers and minifer modules#113
korenlev wants to merge 5 commits intojshimko:masterfrom
korenlev:patch-1

Conversation

@korenlev
Copy link

@korenlev korenlev commented Jul 30, 2018

  1. Adds ENV and ARG for building with http_proxy configuration
  2. Fix a bug in node fibers module lookup when using node versions > 8.x
  3. Remove minify module before buildup, causing misconfigurations.
    I have no authorization to branch and add headers.
    See links to bugs details in commit.

@jshimko
Copy link
Owner

jshimko commented Jul 30, 2018

Could you please add some details in the PR description that explain what this is trying to accomplish?

@korenlev korenlev changed the title Create suggested-fixes-branch Add HTTP_PROXY during build + fix 2 bugs in fibers and minifer modules Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants