Skip to content

Commit

Permalink
remove client from docker compose (#73)
Browse files Browse the repository at this point in the history
* remove client from docker compose

* use 16 for github actions

* fix invalid version

* remove x

* debug install

* debug install

* fix version

* remove lockfile to debug

* put back server install

* rebuild

* rebuild
  • Loading branch information
jshawl authored Mar 10, 2023
1 parent c247855 commit 11eb846
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 25 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [12.x]
node-version: [16.x]
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
Expand Down
1 change: 0 additions & 1 deletion client/.dockerignore

This file was deleted.

10 changes: 0 additions & 10 deletions client/Dockerfile

This file was deleted.

2 changes: 1 addition & 1 deletion client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"socket.io": "^2.3.0"
},
"engines": {
"node": "16.X"
"node": "16.19.1"
},
"scripts": {
"start": "react-scripts start",
Expand Down
8 changes: 0 additions & 8 deletions docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,4 @@
services:
client:
build: client
environment:
DEBUG: "engine,socket.io*"
ports:
- "3000:3000"
volumes:
- ./client:/app/
server:
build: server
depends_on:
Expand Down
3 changes: 3 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"prettier": "^1.19.1"
},
"engines": {
"node": "16.x"
"node": "16.19.1"
},
"devDependencies": {
"eslint": "^6.8.0",
Expand Down
5 changes: 2 additions & 3 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ is a service for inspecting http requests.
## Local Setup

$ git clone https://github.com/jshawl/httpz.git
$ cd server && npm start
$ cd client && yarn start
$ docker-compose up -d
$ cd client && npm start

Make sure [MongoDB](https://www.mongodb.com/) is running on your server.

0 comments on commit 11eb846

Please sign in to comment.