Open
Conversation
b9dd705 to
a52c1f8
Compare
Member
|
Can you reduce this to only the perf improvements? Optimizing bundle size is a non-goal for the jsdom ecosystem. |
04cbd65 to
7b63a8b
Compare
Author
|
@domenic I can file those separately But this package is used by far more than just jsdom, both directly and through |
Member
|
Sure, but, as a maintainer, I do not want to prioritize bundle size. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an
~1.85xgzipped size reduction and an~1.27xperf improvement.Package size, before: 236 KiB minified, 60 KiB gzipped
Package size, after: 152 KiB minified, 32.5 KiB gzipped
Bench:
230,482->292,052ops/secChanges done:
.slice()during mappingmappingis non-existent for somestatusvalues)Further optimization is possible but I decided to stop somewhere for now