Open
Conversation
… in correct location
…Switching to 2.3.2
Owner
|
This is great, thanks for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates colorscad to use lib3mf from vcpkg (see 3MFConsortium/lib3mf#424). I’ve verified that tests pass on all supported platforms.
Dependency update
colorscad was using a very old lib3mf. I initially upgraded to 2.4.1, but the existing test .3mf files do not include newer specs (2.4.1 adds trianglesets and volumetric/implicit specs) and the tests will fail otherwise. To maintain compatibility, this PR pins lib3mf to 2.3.2 in vcpkg.json.
Future upgrade
I recommend regenerating the test .3mf files with lib3mf 2.4.1 to take advantage of the new features. The next lib3mf release will include a static library, so upgrading then will simply require bumping the version in vcpkg.json (and a minor CI tweak).
Please review and merge if this meets your needs.