Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

justinwerner/sc-110/course-ui-designs #68

Open
wants to merge 5 commits into
base: staging
Choose a base branch
from

Conversation

justinwerner
Copy link
Collaborator

Initial course database structure complete and initial course search page finished. This search page will not show results until 4 courses are built. We should withhold from making any courses in production until the entire courses objective is complete.

…page finished. This search page will not show results until 4 courses are built. We should withhold from making any courses in production until the entire courses objective is complete.
@justinwerner justinwerner self-assigned this Feb 17, 2024
Copy link

This pull request has been linked to Shortcut Story #110: Course UI Designs.

Copy link
Owner

@jringeisen jringeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left a few comments for you. Are we planning to create the Nova side in another PR?

resources/js/Pages/Teachers/Courses/Index.vue Outdated Show resolved Hide resolved
resources/js/Pages/Teachers/Courses/Index.vue Outdated Show resolved Hide resolved
resources/js/Pages/Teachers/Courses/Index.vue Outdated Show resolved Hide resolved
app/Http/Controllers/CourseController.php Outdated Show resolved Hide resolved
resources/js/Pages/Teachers/Courses/Index.vue Outdated Show resolved Hide resolved
@justinwerner
Copy link
Collaborator Author

Yes, the Nova side will come in a different PR - and will be merged in first so that some courses will be made before the full rollout.

@jringeisen jringeisen force-pushed the justinwerner/sc-110/course-ui-designs branch from b4ee0f4 to 5b67d45 Compare May 6, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants