Skip to content

Change kill-this-buffer to kill-current-buffer#903

Merged
syohex merged 1 commit intojrblevin:masterfrom
smithzvk:patch-1
Jun 6, 2025
Merged

Change kill-this-buffer to kill-current-buffer#903
syohex merged 1 commit intojrblevin:masterfrom
smithzvk:patch-1

Conversation

@smithzvk
Copy link
Copy Markdown
Contributor

@smithzvk smithzvk commented Jun 5, 2025

Change "q" key binding from kill-this-buffer to kill-current-buffer

Description

From the docs regarding 'kill-this-buffer':

This command must be bound to a mouse event, and can be reliably invoked only from the menu bar, otherwise it could decide to silently do nothing or signal an error. Use ‘kill-current-buffer’ if you need to invoke a similar command from keyboard.

Related Issue

N/A

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have updated the documentation in the README.md file if necessary.
  • I have added an entry to CHANGES.md.
  • I have added tests to cover my changes.
  • All new and existing tests passed (using make test).

From the docs regarding 'kill-this-buffer':

This command must be bound to a mouse event, and can be reliably invoked only from the menu bar, otherwise it could decide to silently do nothing or signal an error.  Use ‘kill-current-buffer’ if you need to invoke a similar command from keyboard.
@syohex syohex merged commit 7c20685 into jrblevin:master Jun 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants