Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types: Add entry for QUnit's Assert type #572

Closed
wants to merge 1 commit into from

Conversation

jzaefferer
Copy link
Member

Ref qunitjs/api.qunitjs.com#58

This implements "1) We put all types on api.jquery.com, even if they have nothing to do with jQuery" from jquery/grunt-jquery-content#54

@jzaefferer
Copy link
Member Author

PR for QUnit API: qunitjs/api.qunitjs.com#89

@@ -639,3 +639,5 @@ <h2 id="Callbacks">Callbacks Object</h2>
<p>A multi-purpose object that provides a powerful way to manage callback lists. It supports adding, removing, firing, and disabling callbacks. The Callbacks object is created and returned by the <code>$.Callbacks</code> function and subsequently returned by most of that function's methods. </p>
<h2 id="XMLDocument">XML Document</h2>
<p>A document object created by the browser's XML DOM parser, usually from a string representing XML. XML documents have different semantics than HTML documents, but most of the traversing and manipulation methods provided by jQuery will work with them.</p>
<h2 id="Assert">Assert</h2>
<p>A reference or instance of the object holding all of QUnit's assertions. See the <a href="//api.qunitjs.com/QUnit.assert">API documentation for <code>QUnit.assert</code></a> for details.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's a reference to the object, then this should read: "A reference to or instance of the object…"

@jzaefferer
Copy link
Member Author

Updated

@scottgonzalez
Copy link
Member

It's been two weeks and there haven't been any objections. Perhaps give @danheberden and @RedWolves a few days to chime in before merging?

@kswedberg
Copy link
Member

Sorry, @scottgonzalez, I already merged this in c21b787, but forgot to close the PR.

@kswedberg kswedberg closed this Oct 27, 2014
@scottgonzalez
Copy link
Member

Ok. Please make sure to always include Closes gh-XXX in commits that start from PRs. See http://contribute.jquery.org/commits-and-pull-requests/#commit-guidelines.

@kswedberg
Copy link
Member

yep. just forgot this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants