Fix CMake policy CMP0175 warning and improve test documentation#162
Open
colinrlim wants to merge 2 commits intojpbruyere:masterfrom
Open
Fix CMake policy CMP0175 warning and improve test documentation#162colinrlim wants to merge 2 commits intojpbruyere:masterfrom
colinrlim wants to merge 2 commits intojpbruyere:masterfrom
Conversation
Add explicit POST_BUILD parameter to ADD_CUSTOM_COMMAND at line 227 to comply with CMake policy CMP0175. This eliminates six repeated warnings during CMake configuration on modern CMake versions. The command generates shader headers after the BuildShadersHeader target is built, so POST_BUILD is the appropriate timing.
Add Testing section to CONTRIBUTING.md explaining how to build and run unit tests, and clarifying first-run behavior when visual regression tests skip to generate reference images. This addresses potential confusion for first-time contributors.
Owner
|
Just saw your PR, sorry for the delay, was in novels and in economic théories... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses build warnings on modern CMake versions and improves contributor documentation for testing.
Changes
POST_BUILDparameter toADD_CUSTOM_COMMANDat line 227, eliminating six repeated warnings during CMake configurationTesting
Motivation
When building vkvg with modern CMake (3.31+), six warnings about deprecated API usage were produced. Additionally, visual regression tests skip on first run to generate reference images, which could confuse new contributors without documentation.
Environment Tested