Adding test support for Django 2.0 / DRF 3.7, 3.8 #443
Conversation
Codecov Report
@@ Coverage Diff @@
## master #443 +/- ##
==========================================
- Coverage 90.67% 90.36% -0.31%
==========================================
Files 14 12 -2
Lines 847 820 -27
Branches 29 29
==========================================
- Hits 768 741 -27
Misses 66 66
Partials 13 13
Continue to review full report at Codecov.
|
|
Can I have any feedback on this pull request? Also, are you moving the project to GitLab or staying on GitHub? |
There was a problem hiding this comment.
One bit needs fixing, but then maybe just switch to using https://github.com/Styria-Digital/django-rest-framework-jwt which is on PyPI as drf-jwt and is a drop-in replacement for the original ;-)
| drf3 = rest_framework.VERSION >= StrictVersion('3.0.0') | ||
|
|
||
| django_strict_version = StrictVersion('%s.%s.%s' % django.VERSION[:3]) | ||
| django2 = django_strict_version > StrictVersion('1.10.0') |
There was a problem hiding this comment.
And then Django 1.11 happened ;-)
In any case, the older PR #398 did this.
2 participants
Hello.
I updated the test skip in
test_serializersas it was comparing the Django version to 1.10 by checking only the second digit, which fails for Django 2.0. I also updated the tox.ini, .travis.yml and the documentation accordingly.I removed the 3.3 tests as it fails the test (can't create the virtualenv, the bug is found here: tox-dev/tox#644).