Fixes #290 -- Pass request object on authenticate()#395
Fixes #290 -- Pass request object on authenticate()#395jezeniel wants to merge 2 commits intojpadilla:masterfrom
Conversation
|
Need opinions and tips on how to add test case for this one. |
Django 1.11 introduced def authenticate(request, ...). This would be useful for some authentications with additional data. i.e. multiple user types.
Codecov Report
@@ Coverage Diff @@
## master #395 +/- ##
==========================================
+ Coverage 90.67% 90.73% +0.06%
==========================================
Files 14 14
Lines 847 853 +6
Branches 29 30 +1
==========================================
+ Hits 768 774 +6
Misses 66 66
Partials 13 13
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #395 +/- ##
==========================================
+ Coverage 90.67% 90.73% +0.06%
==========================================
Files 14 14
Lines 847 853 +6
Branches 29 30 +1
==========================================
+ Hits 768 774 +6
Misses 66 66
Partials 13 13
Continue to review full report at Codecov.
|
|
Any updates for this one? |
|
I vote for this, as it also affects me, and the patch works for me well |
Django 1.11 introduced
def authenticate(request, ...).This would be useful for some authentications with additional data.
i.e. multiple user types.