Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistency and styling improvements #248

Merged
merged 23 commits into from
Jan 26, 2025
Merged

Consistency and styling improvements #248

merged 23 commits into from
Jan 26, 2025

Conversation

jp7677
Copy link
Owner

@jp7677 jp7677 commented Jan 25, 2025 •
edited
Loading

Just nits and IDE hints. Should change nothing, just makes everything a bit more consistent.

Related: #241

@jp7677 jp7677 marked this pull request as ready for review January 25, 2025 19:51
@jp7677 jp7677 requested a review from Saancreed January 25, 2025 20:01
@jp7677
Copy link
Owner Author

jp7677 commented Jan 25, 2025

Review per commit is probably easier.

Saancreed
Saancreed reviewed Jan 25, 2025
View reviewed changes
src/nvapi/lfx.cpp Outdated Show resolved Hide resolved
src/nvapi/resource_factory.cpp Outdated Show resolved Hide resolved
src/util/util_log.cpp Outdated Show resolved Hide resolved
jp7677 added 23 commits January 25, 2025 22:13
@jp7677
nvapi: Shorten raw pointer checks
f9499bc 
More consistent with other parts of the code base.
@jp7677
nvapi: Use cpp-style casts
d8d1db8 
IDE hint.
@jp7677
nvapi-d3d: Declare functions const
920c0eb 
IDE hint
@jp7677
nvapi: Move assignment into switch statement
f3156a0 
IDE hint.
@jp7677
nvapi: Use constexpr
59c9f41 
IDE hint.
@jp7677
nvapi: Use full qualifier
639d1a4 
IDE hint.
@jp7677
nvofapi: Add pragma
1495246 
IDE hint.
@jp7677
nvofapi: Use cpp-style casts
8900c6d 
IDE hint.
@jp7677
nvofapi: Declare some functions const
6953453 
IDE hint.
@jp7677
nvofapi: Add missing override keyword
3c420e2 
IDE hint.
@jp7677
nvofapi: Remove not needed braces
f36ca0c 
IDE hint.
@jp7677
nvofapi: Shorten raw pointer checks
ff0003b 
More consistent with other parts of the code base.
@jp7677
util: Shorten raw pointer checks
19e23b2 
More consistent with other parts of the code base.
@jp7677
util: Use cpp-style casts
b5a56e5 
IDE hint.
@jp7677
util: Move assignment into if statement
18b977d 
IDE hint.
@jp7677
util: Add typename keyword
dbd9a47 
IDE hint.
@jp7677
tests: Add pragma
5a1e712 
IDE hint.
@jp7677
tests: Shorten raw pointer checks
fac608a
@jp7677
tests: Use cpp-style casts
0902f32 
IDE hint.
@jp7677
tests: Declare function const
ce01f9b 
IDE hint.
@jp7677
tests: Remove not needed include
73773e4 
IDE hint.
@jp7677
tests: Move variable to inner scope
fc496ba 
IDE hint.
@jp7677
tests: Use string.empty()
d6e11b5 
IDE hint.
@jp7677 jp7677 merged commit d6e11b5 into master Jan 26, 2025
4 checks passed
@jp7677 jp7677 deleted the qol-1 branch January 26, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saancreed Saancreed Saancreed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jp7677 @Saancreed