Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quality-of-life improvements #241

Open
3 of 10 tasks
jp7677 opened this issue Jan 8, 2025 · 0 comments
Open
3 of 10 tasks

Quality-of-life improvements #241

jp7677 opened this issue Jan 8, 2025 · 0 comments
Labels
good first issue Good for newcomers

Comments

@jp7677
Copy link
Owner

jp7677 commented Jan 8, 2025 •
edited
Loading

Just an unordered list of not so important things for long evenings:

  • Replace x == nullptr check with !x for consistency
  • Look through IDE suggestions (consider C++20 features, e.g. std::ranges?)
  • Add tests for VkReflex once that PR has landed
  • Reuse ResourceFactory and Vk for nvofapi
  • Add tests for nvofapi
  • Resolve "used after move" warning properly in tests
  • Consider more abstraction/reuse for tests
  • Improve cleanup for VK-Reflex tests (in case of a test failure, the test suite stops because NvapiVulkanLowLatencyDevice::Reset() called for cleanup, calls vkDestroySemaphore with trompeloeil::expectations already out of scope. See ResetGlobals())
  • Remove GB defines in nvapi_private once updated NVAPI headers are available (also update https://github.com/jp7677/dxvk-nvapi/blob/master/tests/nvapi_system.cpp#L58-L59)
  • Include VkHeaders from SDK tag?

If someone beats me for any of those points, that's fine of course ;)
@jp7677 jp7677 added the good first issue Good for newcomers label Jan 8, 2025
@jp7677 jp7677 changed the title TODO list of smaller things Quality-of-life improvements Jan 9, 2025
@jp7677 jp7677 mentioned this issue Jan 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jp7677