Expose a stream with indexer state changes #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…complete event for now)
|
@desfero is attempting to deploy a commit to the joshaavecom's projects Team on Vercel. A member of the Team first needs to authorize it. |
desfero
commented
Jan 5, 2026
| .filter(|c| c.details.iter().any(|p| p.end_block.is_none())) | ||
| .count() | ||
| > 0 | ||
| self.all_contracts().iter().any(|c| c.details.iter().any(|p| p.end_block.is_none())) |
Contributor
Author
There was a problem hiding this comment.
just nit, we don't need to loop through all values in the array
desfero
commented
Jan 5, 2026
| ) | ||
| .await | ||
| .map_err(StartRindexerError::CouldNotStartIndexing)?; | ||
| if manifest.has_any_contracts_live_indexing() { |
Contributor
Author
There was a problem hiding this comment.
This fixes the issue that was affecting historical indexing when there was no relationship
// we index all the historic data first before then applying FKs
!relationships.is_empty(),
Now historical indexing duration log is always there which makes codebase more cohesive
desfero
force-pushed
the
pawel/stream-indexer-state-change-events
branch
from
c1d3317 to
98cc98e
Compare
joshstevens19
requested changes
Jan 5, 2026
Owner
joshstevens19
left a comment
joshstevens19
left a comment
There was a problem hiding this comment.
changelog rest looks good!
joshstevens19
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.