Feature/banking api's #163

arpita-josh02 · 2025-10-17T06:57:29Z

-added v2 api where modify response struture

Summary by Bito

This pull request introduces version 2 of the banking API, enhancing response structures and adding functionalities like improved beneficiary search, balance retrieval, and money transfer. It also includes new endpoints for detailed queries, better error handling, and updates to configuration management. Additionally, a new API endpoint for processing audio files has been added, featuring transcription and intent detection capabilities.

…into feature/banking_api's

Copilot

Pull Request Overview

This pull request introduces version 2 of the banking API with enhanced response structures and adds a new Langflow integration endpoint for processing voice inputs. The changes include improved beneficiary search with normalization, restructured API responses with status/message/data fields, and a new async HTTP client lifecycle management for external API calls.

Key changes:

New /voice/process-with-langflow endpoint that transcribes audio and processes it through Langflow for intent detection
V2 banking routes with improved error messages, beneficiary matching, and standardized response format
Langflow API configuration and integration utilities

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.

File	Description
service/main.py	Adds Langflow integration endpoint with audio processing, async HTTP client lifecycle management, and switches to v2 banking routes
service/config.py	Duplicates configuration variables and adds Langflow API settings including hardcoded API keys
service/banking/core_banking_routes_v2.py	Implements v2 banking API with improved beneficiary search, normalized text matching, and structured JSON responses

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-27T08:45:50Z

service/config.py

+import os
+from dotenv import load_dotenv
+
+load_dotenv()
+
+openai_api_key = os.getenv("OPENAI_API_KEY")
+#model_id = os.getenv('MODEL_ID', 'large-v3')
+model_id = os.getenv('MODEL_ID','small')
+model_path = os.getenv('MODEL_PATH', './models')
+ollama_host = os.getenv("OLLAMA_HOST", "http://ollama:11434")
+ollama_model_name = os.getenv("OLLAMA_MODEL_NAME", "llama3.2")
+open_ai_model_name = os.getenv("OPENAI_MODEL_NAME", "gpt-4")
+ollama_translation_model_name = os.getenv("OLLAMA_TRANS_MODEL","gemma2:latest")
+open_ai_temperature = os.getenv("OPENAI_TEMPERATURE", 0.2)
+db_user = os.getenv("DB_USER")
+db_password = os.getenv("DB_PASSWORD")
+db_host = os.getenv("DB_HOST")
+db_port = os.getenv("DB_PORT")
+db_name = os.getenv("DB_NAME")
+
+sarvam_api_key = os.getenv("SARVAM_API_KEY","sk_t7fvsjjb_7JsD5ZXGrEhHqjUtAQSFsCxB")
+# Redis configuration
+redis_host = os.getenv("REDIS_HOST", "localhost")
+redis_port = int(os.getenv("REDIS_PORT", 6379))
+redis_db = int(os.getenv("REDIS_DB", 0))
+redis_password = os.getenv("REDIS_PASSWORD", None)
+


The configuration variables from lines 27-52 are duplicating those already defined at lines 1-26, creating code duplication. Remove this duplicate block to avoid inconsistencies and maintenance issues.

Suggested change

import os

from dotenv import load_dotenv

load_dotenv()

openai_api_key = os.getenv("OPENAI_API_KEY")

#model_id = os.getenv('MODEL_ID', 'large-v3')

model_id = os.getenv('MODEL_ID','small')

model_path = os.getenv('MODEL_PATH', './models')

ollama_host = os.getenv("OLLAMA_HOST", "http://ollama:11434")

ollama_model_name = os.getenv("OLLAMA_MODEL_NAME", "llama3.2")

open_ai_model_name = os.getenv("OPENAI_MODEL_NAME", "gpt-4")

ollama_translation_model_name = os.getenv("OLLAMA_TRANS_MODEL","gemma2:latest")

open_ai_temperature = os.getenv("OPENAI_TEMPERATURE", 0.2)

db_user = os.getenv("DB_USER")

db_password = os.getenv("DB_PASSWORD")

db_host = os.getenv("DB_HOST")

db_port = os.getenv("DB_PORT")

db_name = os.getenv("DB_NAME")

sarvam_api_key = os.getenv("SARVAM_API_KEY","sk_t7fvsjjb_7JsD5ZXGrEhHqjUtAQSFsCxB")

# Redis configuration

redis_host = os.getenv("REDIS_HOST", "localhost")

redis_port = int(os.getenv("REDIS_PORT", 6379))

redis_db = int(os.getenv("REDIS_DB", 0))

redis_password = os.getenv("REDIS_PASSWORD", None)

Copilot · 2025-10-27T08:45:50Z

service/config.py

+db_port = os.getenv("DB_PORT")
+db_name = os.getenv("DB_NAME")
+
+sarvam_api_key = os.getenv("SARVAM_API_KEY","sk_t7fvsjjb_7JsD5ZXGrEhHqjUtAQSFsCxB")


Hardcoded API key in default value exposes sensitive credentials in source code. Remove the default value and require this key to be set via environment variables only.

Suggested change

sarvam_api_key = os.getenv("SARVAM_API_KEY","sk_t7fvsjjb_7JsD5ZXGrEhHqjUtAQSFsCxB")

sarvam_api_key = os.getenv("SARVAM_API_KEY")

Copilot · 2025-10-27T08:45:50Z

service/config.py

+# Langflow API configuration
+langflow_api_url = os.getenv("LANGFLOW_API_URL", "http://localhost:7860")
+langflow_flow_id = os.getenv("LANGFLOW_FLOW_ID", "df6ef421-30ef-4901-bc8b-270c2ce61d41")
+langflow_api_key = os.getenv("LANGFLOW_API_KEY", "sk-SCQyDlsYB7qPzmzL3yivQs-J5JmvX82uHVbDiGWrQR8")


Hardcoded API key in default value exposes sensitive credentials in source code. Remove the default value and require this key to be set via environment variables only.

Suggested change

langflow_api_key = os.getenv("LANGFLOW_API_KEY", "sk-SCQyDlsYB7qPzmzL3yivQs-J5JmvX82uHVbDiGWrQR8")

langflow_api_key = os.getenv("LANGFLOW_API_KEY")

Copilot · 2025-10-27T08:45:51Z

service/main.py

+        # # Verify request has required authentication
+        # server_api_key = langflow_api_key
+        # if server_api_key:
+        #     return JSONResponse(
+        #         status_code=401, 
+        #         content={"message": "Invalid API key. Please provide a valid API key to access this endpoint."}
+        #     )


Commented-out authentication check leaves endpoint unprotected. The logic at line 279 is also incorrect (would reject valid keys). Either implement proper authentication or remove this commented code.

Suggested change

# # Verify request has required authentication

# server_api_key = langflow_api_key

# if server_api_key:

# return JSONResponse(

# status_code=401,

# content={"message": "Invalid API key. Please provide a valid API key to access this endpoint."}

# )

# Verify request has required authentication

if langflow_api_key:

if not api_key or api_key != langflow_api_key:

return JSONResponse(

status_code=401,

content={"message": "Invalid API key. Please provide a valid API key to access this endpoint."}

)

Copilot · 2025-10-27T08:45:51Z

service/banking/core_banking_routes_v2.py

+    if len(matches) > 1:
+        # Multiple partial matches - return formatted list
+        beneficiary_list = format_beneficiaries(matches)
+        return HTTPException(


Should raise the HTTPException instead of returning it. Change return HTTPException(...) to raise HTTPException(...).

Suggested change

return HTTPException(

raise HTTPException(

Copilot · 2025-10-27T08:45:51Z

service/banking/core_banking_routes_v2.py

+            status_code=status.HTTP_400_BAD_REQUEST,
+            detail="To transfer money, please provide either a customer ID or a registered phone number."
+        )
+    print(request)


Debug print statement should be replaced with proper logging using the logger. Change to logger.debug(f\"Payment request: {request}\").

Copilot · 2025-10-27T08:45:51Z

service/banking/core_banking_routes_v2.py

+        for b in beneficiaries
+    ]
+
+    return{"beneficiaries": beneficiaries}


Response format is inconsistent with other v2 endpoints which return {\"status\": \"success\", \"message\": \"...\", \"data\": {...}}. Update to match the standard v2 response structure for consistency.

Suggested change

return{"beneficiaries": beneficiaries}

return {

"status": "success",

"message": "Beneficiaries retrieved successfully.",

"data": {"beneficiaries": beneficiaries}

}

Copilot · 2025-10-27T08:45:52Z

service/main.py

+
+        logger.info(f"Calling Langflow API at {url}")
+        # Make the API call
+        async with httpx.AsyncClient(timeout=langflow_timeout) as client:


Creating a new AsyncClient for each request is inefficient. Use the app.state.langflow_client created in the lifespan context manager instead: await app.state.langflow_client.post(...).

arpita-josh02 added 28 commits September 23, 2025 13:03

banking api's

34066cd

changes request parm as per frontend

e64cda4

new changes

674ab42

remove default cred from file take from env

5756af4

move database cred to config file

b98a800

upadted chnages

b78de13

added details message in response

681bbd9

added customer id in api response

4e4210d

modify seed data and response of benificary

692406f

merge with main

b734a1f

Merge branch 'lingo/main' of https://github.com/joshsoftware/lingo.ai …

d3384ca

…into feature/banking_api's

added customer name in api

4aa357a

Merge branch 'lingo/main' of https://github.com/joshsoftware/lingo.ai …

6259cde

…into feature/banking_api's

added transcation in pay money and optimise code

fa959d4

Merge branch 'lingo/main' of https://github.com/joshsoftware/lingo.ai …

ce60600

…into feature/banking_api's

correctd file name

ced011d

Merge branch 'lingo/main' of https://github.com/joshsoftware/lingo.ai …

b0e3e0b

…into feature/banking_api's

updated response and deleted wrong file

376d84d

resloved merge confilts

3d3455f

corrected intent and seed data

242634a

Merge branch 'lingo/main' of https://github.com/joshsoftware/lingo.ai …

361172f

…into feature/banking_api's

Merge branch 'lingo/main' of https://github.com/joshsoftware/lingo.ai …

c8c9fce

…into feature/banking_api's

Merge branch 'lingo/main' of https://github.com/joshsoftware/lingo.ai …

436432a

…into feature/banking_api's

updated transcation response

6745e45

Merge branch 'lingo/main' of https://github.com/joshsoftware/lingo.ai …

0973b87

…into feature/banking_api's

Merge branch 'lingo/main' of https://github.com/joshsoftware/lingo.ai …

e18db9b

…into feature/banking_api's

add v2 api for bank

d2675f9

chages releted to connect langflow and code

435c446

sethu requested a review from Copilot October 27, 2025 08:43

Copilot AI reviewed Oct 27, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature/banking api's #163

Feature/banking api's #163

Uh oh!

arpita-josh02 commented Oct 17, 2025 •

edited by bito-code-review bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 27, 2025

Uh oh!

Copilot AI Oct 27, 2025

Uh oh!

Copilot AI Oct 27, 2025

Uh oh!

Copilot AI Oct 27, 2025

Uh oh!

Copilot AI Oct 27, 2025

Uh oh!

Copilot AI Oct 27, 2025

Uh oh!

Copilot AI Oct 27, 2025

Uh oh!

Copilot AI Oct 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	sarvam_api_key = os.getenv("SARVAM_API_KEY","sk_t7fvsjjb_7JsD5ZXGrEhHqjUtAQSFsCxB")
	sarvam_api_key = os.getenv("SARVAM_API_KEY")

	langflow_api_key = os.getenv("LANGFLOW_API_KEY", "sk-SCQyDlsYB7qPzmzL3yivQs-J5JmvX82uHVbDiGWrQR8")
	langflow_api_key = os.getenv("LANGFLOW_API_KEY")

-    return{"beneficiaries": beneficiaries}
+    return {
+        "status": "success",
+        "message": "Beneficiaries retrieved successfully.",
+        "data": {"beneficiaries": beneficiaries}
+    }

Feature/banking api's #163

Are you sure you want to change the base?

Feature/banking api's #163

Uh oh!

Conversation

arpita-josh02 commented Oct 17, 2025 • edited by bito-code-review bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Bito

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

arpita-josh02 commented Oct 17, 2025 •

edited by bito-code-review bot

Loading