Skip to content

fix: infer the correct type for D > 1 arrays in multiply function#3408

Merged
josdejong merged 5 commits intojosdejong:developfrom
orelbn:orelbn/fix-multiply-typing
Feb 27, 2025
Merged

fix: infer the correct type for D > 1 arrays in multiply function#3408
josdejong merged 5 commits intojosdejong:developfrom
orelbn:orelbn/fix-multiply-typing

Conversation

@orelbn
Copy link
Copy Markdown
Contributor

@orelbn orelbn commented Feb 25, 2025

Description

Test

  • Added test based on issue example

Assumptions

  • Assumes that multiplication of arrays of the same dimensionality greater than 1 results in an array of the same dimensionality. (I believe that we currently only support the multiplication of matrix/arrays of D <= 2)

Additional Notes

  • Please let me know if you can think of any other tests that I should add :)

@orelbn orelbn mentioned this pull request Feb 25, 2025
@orelbn orelbn changed the title fix: infer the correct type for 2D arrays in multiply function fix: infer the correct type for D > 1 arrays in multiply function Feb 25, 2025
@josdejong
Copy link
Copy Markdown
Owner

Thanks Orel, that is a neat fix.

@josdejong josdejong merged commit 5c121f5 into josdejong:develop Feb 27, 2025
8 checks passed
@josdejong
Copy link
Copy Markdown
Owner

Published now in v14.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants