Rename files to the more commenly used (in Go projects) snake_case #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svanharmelen
force-pushed
the
chore/file_names
branch
2 times, most recently
from
08f4d42 to
885be6d
Compare
ccoVeille
approved these changes
Dec 10, 2024
|
There is a new revive rule for validating the filenames Please add Fixing the names is good, but making sure no more errors I'll be done is also important |
|
There is also new revive rule for validating variables name Please add |
svanharmelen
force-pushed
the
chore/file_names
branch
from
885be6d to
a748df4
Compare
|
Found two additional variables due to configuring the |
In addition one struct field is renamed to follow the initialisms guideline: https://go.dev/wiki/CodeReviewComments#initialisms
svanharmelen
force-pushed
the
chore/file_names
branch
from
a748df4 to
f69ecc7
Compare
ccoVeille
approved these changes
Dec 12, 2024
Nice one to me @ccoVeille , no ? 😂😅 |
|
Oops... Yes, nice one @ccoVeille 😉 |
|
Hahaha good work guys. |
ccoVeille
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition renamed a few identifiers to follow the initialisms guideline:
https://go.dev/wiki/CodeReviewComments#initialisms