translate the Cephes log_exp functions into pure Rust
#177
+206
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR translates the Cephes log_exp functions from C++ FFI bindings to pure Rust implementations. The functions are now implemented directly in Rust, removing the need for C++ wrapper code generation.
- All five
log_expfunctions (expit,exprel,logit,log_expit,log1mexp) are now pure Rust implementations - Comprehensive documentation added with LaTeX/KaTeX math expressions and links to scipy.special
- Build configuration updated to remove C++ binding generation for these functions
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/xsf/log_exp.rs | Replaces C++ FFI calls with pure Rust implementations and adds comprehensive documentation for all five log/exp functions |
| src/lib.rs | Updates documentation tables with proper formatting and adds log1mexp to the "Other special functions" section |
| build.rs | Removes log_exp.h from wrapper includes and removes function binding specifications for the five translated functions |
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.