PDF Annotation & Template creation from a PDF. Bug fixes.#27
PDF Annotation & Template creation from a PDF. Bug fixes.#27AstyCX wants to merge 10 commits intojonjampen:masterfrom
Conversation
…(for non gzipped)
… templates, code clarity fixes.
…pearing fixed. File segregation added.
… the created templates to be fixed.
…ted, dimensions fixed.
|
Is that feature available now? To create a xopp file that has a pdf as background? Why not just open the pdf file in Xournal++ for the user to save / choose name + folder later? I would rather do that in my normal workflow than having it auto-create a xopp file. |
diam0ndkiller
left a comment
diam0ndkiller
left a comment
There was a problem hiding this comment.
I think it's smarter to just comment here instead of forking your fork again and making random changes :)
| height: dimensions.height, | ||
| pdfPage: await getPageCount(file, app) | ||
| }; | ||
| } |
There was a problem hiding this comment.
Add function to open PDF in Xournal++ instead of creating new .xopp file with background - e.g. openInXOPP(file, app)
|
|
||
|
|
||
| function addAnnotatePdfInXournalppMenu(menu: Menu, plugin: XoppPlugin, file: TFile) { | ||
| menu.addItem((item) => { |
There was a problem hiding this comment.
two buttons, one for "annotate" and one for "annotate & autosave" maybe? otherwise maybe add toggle in settings whether to just open pdf in xournal or to create a new xopp with pdf as background to auto-save
| } | ||
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
"Automatically save annotated PDF when choosing annotate in file menu" maybe
2 participants
PDF Annotation
Added a feature to annotate a chosen PDF from Obsidian. By right-clicking a file with the .pdf extension, “Annotate in Xournal++” will appear in the menu. By choosing it, a -annotated.xopp file will be created (with a corresponding .pdf if the Export to PDF setting is on).
PDF Template Creation
Added PDF to the list of styles in the template creation modal. When creating a new template through settings, you can now choose to create a template from a PDF. It will suggest choosing a PDF either by entering an absolute path on your system or by using a fuzzy search modal inside your vault.
After choosing the PDF, the following settings are applied:
Fixes