Replace mpsc::{Sender,Receiver} by VecDeque#260
Conversation
876857e to
f0a6515
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
jonhoo
left a comment
There was a problem hiding this comment.
Thanks for taking the time to make this change! And sorry for the slow reply 😅
Just one bit in there that I think is wrong, otherwise looks good 👍
|
Hi @soywod I really like this PR and it also looks super close to being finished. Is there anyway I can help get this merged? |
|
I forgot about this PR as it did not fix my initial issue. I can take a look back during this week and see if I can complete it. |
47a0c4d to
bb60096
Compare
0aa822e to
6bc124f
Compare
|
Sorry for the very long delay. The PR is ready for another review! |
jonhoo
left a comment
There was a problem hiding this comment.
Excellent, thank you! A few instances of one change I'd like to see (I'll just commit those), and otherwise two questions.
For better errors when tests fail
Made Session::unsolicited_responses pub(crate), and renamed Session::all_unsolicited to take_all_unsolicited.
jonhoo
left a comment
There was a problem hiding this comment.
Hey, we managed to land it before two years passed 😂
Mostly my fault — thanks for sticking with it!
Fixes #254.
This change is