fix mapping array of enums to setter which expects array of enums #280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #269
I found out that this bug was introduced in #230, to be more precise this lines ArrayTransformerFactory.
Before #230
$targetCollections
would be equal[]
so we would getreturn new DictionaryTransformer(new CopyTransformer());
. And CopyTransformer would just pass enums from property tosetPaymentMethods()
.But simply removing this lines wouldn't work because they do serve they purpose in fixing weird behavior in #230.
So I dug further and found out original issue.
Here WriteMutator should get that
setPaymentMethods()
expectsPaymentMethod[]
but gets blocked here GetTypeTrait because argument$property
equals'setPaymentMethods'
and we get this check that result in false and we skip trying to extract types