Skip to content

chore(server): run API and WebSocket servers in parallel using concurrently #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Misterr-H wants to merge 1 commit into
base: main
Choose a base branch
from
+59 −12
Open

chore(server): run API and WebSocket servers in parallel using concurrently #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions apps/server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
"type": "module",
"private": true,
"scripts": {
"dev": "nodemon --exec tsx src/index.ts",
"dev": "concurrently -k -n api,ws -c green,blue \"nodemon --exec tsx src/index.ts\" \"tsx src/mediasoup-server.ts\"",
"yassr": "tsx src/ws-signaling.ts",
"dev:hot": "nodemon --exec tsx src/index.ts",
"build": "tsc --build",
"start": "node dist/index.js",
"start": "concurrently -k -n api,ws -c green,blue \"node dist/index.js\" \"node dist/mediasoup-server.js\"",
"ws": "tsx src/mediasoup-server.ts"
Comment on lines +10 to 11
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

start script depends on a dev-only package – production will fail

concurrently lives in devDependencies, yet the start script (used in production containers/hosts) invokes it.
Any production install executed with --production (or PNPM’s --prod) drops dev deps, so node dist/index.js & node dist/mediasoup-server.js will never start:

Error: Cannot find module 'concurrently'

Move the package to dependencies, or replace the script with a runtime process manager available in prod.

@@
   "dependencies": {
     …,
     "zod": "^3.25.67",
+    "concurrently": "^8.2.2"
   },
   "devDependencies": {
     …,
-    "concurrently": "^8.2.2"
   }

Also applies to: 41-41

🤖 Prompt for AI Agents 
In apps/server/package.json around lines 10 to 11 and line 41, the "start"
script uses the "concurrently" package which is listed under devDependencies,
causing production installs with --production to fail due to missing this
package. To fix this, either move "concurrently" from devDependencies to
dependencies to ensure it is installed in production, or replace the "start"
script with a command that uses a runtime process manager available in
production environments.

},
"dependencies": {
Expand Down Expand Up @@ -37,6 +37,7 @@
"nodemon": "^3.1.10",
"ts-node": "^10.9.2",
"tsx": "^4.7.0",
"typescript": "^5.7.3"
"typescript": "^5.7.3",
"concurrently": "^8.2.2"
}
}
64 changes: 55 additions & 9 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.