Skip to content

Conversation

@iaugusty
Copy link
Collaborator

@iaugusty iaugusty commented Sep 1, 2025

vignette for formats

@iaugusty iaugusty linked an issue Sep 1, 2025 that may be closed by this pull request
@iaugusty iaugusty marked this pull request as draft September 1, 2025 13:43
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025

badge

Code Coverage Summary

Filename                                        Stmts    Miss  Cover    Missing
--------------------------------------------  -------  ------  -------  ------------------------------------------------------------------------------------------------------------------------------------------------------
R/a_eair_j.R                                      233      11  95.28%   33-35, 148, 174, 522, 604-607, 635
R/a_freq_combos_j.R                                80       1  98.75%   69
R/a_freq_j.R                                      339      56  83.48%   93, 99, 132-140, 153-157, 164-173, 279-287, 301-305, 311, 318-322, 650-653, 658, 664-666, 721, 755, 759-761, 784-788
R/a_freq_resp_var_j.R                              91      38  58.24%   65-70, 114-125, 153-178
R/a_freq_subcol_j.R                                76       3  96.05%   61-63
R/a_summarize_aval_chg_diff.R                     207      42  79.71%   27-34, 47, 101-102, 134, 138-140, 147, 152-154, 179, 198-204, 407, 411, 415, 430-433, 446, 449, 465, 488-494, 507
R/a_summarize_ex_j.R                              107      17  84.11%   80, 100-107, 213, 217, 221, 249-253, 281
R/analyze_values.R                                 11       0  100.00%
R/ancova_rbmi.R                                    70       0  100.00%
R/ancova.R                                         63       1  98.41%   74
R/blank_line.R                                     26       0  100.00%
R/cmp_functions.R                                  28       2  92.86%   59, 70
R/column_stats.R                                  139      40  71.22%   30-48, 89, 107-116, 123-125, 127-139
R/colwidths.R                                     304      96  68.42%   19, 33-102, 107, 131, 253, 260, 306, 324-343, 352-366, 370-376, 381, 392, 404-412, 442-453, 506, 513
R/count_denom_fraction.R                           28       7  75.00%   81, 86-89, 93, 115
R/coxph_hr.R                                       91       0  100.00%
R/coxreg_multivar.R                                58       0  100.00%
R/dps_markup_to_rtf.R                              31      10  67.74%   93-105
R/estimate_proportion_diff.R                       45       0  100.00%
R/event_free.R                                     44       0  100.00%
R/get_ref_info.R                                   14       0  100.00%
R/h_eair_funs.R                                    21       0  100.00%
R/h_freq_funs.R                                   303      51  83.17%   29, 124, 140, 210-219, 241-244, 247-250, 316-322, 362, 366, 370, 374, 378, 418, 431-432, 477, 496, 502, 611, 670, 672, 676, 680-681, 685-690, 710, 731
R/jjcs_num_formats.R                               48       0  100.00%
R/jjcsformats.R                                   238      81  65.97%   28-38, 38-39, 39-40, 40-50, 56-58, 58-62, 64-65, 70-92, 92-97, 99-105, 157, 169, 178, 181, 186, 191, 283, 293, 306, 308, 311, 314, 359
R/junco_utils_default_stats_formats_labels.R       48       0  100.00%
R/kaplan_meier.R                                   48       0  100.00%
R/lsmeans.R                                       128       7  94.53%   55-59, 76-77
R/mmrm_rbmi.R                                      61       0  100.00%
R/mmrm.R                                          104       4  96.15%   42, 64, 104, 155
R/odds_ratio.R                                    164      12  92.68%   118-128, 162-165
R/pool_rbmi.R                                      44      27  38.64%   8-40
R/proportions.R                                    60       1  98.33%   132
R/pruning_functions.R                             175       8  95.43%   169, 316, 319, 355, 365, 401, 442-443
R/rbmi.R                                          124      74  40.32%   125, 131, 375-468
R/relative_risk.R                                  97       5  94.85%   228, 242-245
R/remove_col_count.R                                4       0  100.00%
R/resp01_functions.R                              159      28  82.39%   143-151, 178, 341, 344-353, 355-361
R/s_functions.R                                    27       4  85.19%   4, 7, 16-17
R/sorting_functions.R                              49       2  95.92%   175, 189
R/span_var_map.R                                   15       0  100.00%
R/split_functions.R                               122      31  74.59%   62, 69, 77-95, 103, 106, 113, 116-120, 126, 134-139
R/summarize_ancova.R                              240      52  78.33%   34, 91, 94-117, 120, 124-132, 156-163, 230-233, 241-248
R/summarize_mmrm.R                                 79       0  100.00%
R/summarize_row_counts.R                            8       0  100.00%
R/tabulate_lsmeans_wide.R                         134       0  100.00%
R/tabulate_lsmeans.R                               68       4  94.12%   86-89
R/tabulate_rbmi.R                                 111       0  100.00%
R/tern_utils_default_stats_formats_labels.R       178      17  90.45%   61-68, 71-74, 215-216, 276-277, 326
R/test_proportion_diff.R                           77       1  98.70%   197
R/title_footers.R                                  53      10  81.13%   5, 19-25, 90, 98, 140, 144
R/tt_to_tblfile.R                                 480      49  89.79%   38, 41, 44, 81, 96, 99, 118, 146, 162-176, 198, 208-214, 321-325, 349, 355-357, 361-364, 458-463, 577, 676
R/unicodify.R                                       4       0  100.00%
R/visit_levels.R                                    8       0  100.00%
TOTAL                                            5564     792  85.77%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: d79ebfe

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
count_pct 💚 $7.78$ $-3.92$ $-14$ $+10$ $0$ $0$
rbmi 💚 $17.46$ $-11.80$ $-10$ $+5$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
count_pct 💚 $2.13$ $-1.09$ a_freq_j_as_cfun
count_pct 💚 $1.72$ $-1.21$ a_freq_j_with_N_subgroup_as_denom
rbmi 💚 $9.30$ $-3.75$ Parallisation_works_with_rbmi_analyse_and_produces_identical_results
rbmi 💚 $2.05$ $-2.04$ make_rbmi_cluster_exports_objects_and_loads_packages
rbmi 💚 $1.98$ $-1.96$ make_rbmi_cluster_handles_existing_cluster
rbmi 💚 $1.96$ $-1.95$ make_rbmi_cluster_loads_rbmi_namespaces_correctly
rbmi 💚 $2.09$ $-2.08$ par_lapply_works_with_and_without_cluster

Results for commit 230d894

♻️ This comment has been updated with latest results.

@iaugusty iaugusty changed the base branch from dev to main September 1, 2025 13:56
iaugusty and others added 4 commits September 1, 2025 16:07
Co-authored-by: David Muñoz Tord <[email protected]>
Co-authored-by: David Muñoz Tord <[email protected]>
Co-authored-by: David Muñoz Tord <[email protected]>
Co-authored-by: David Muñoz Tord <[email protected]>


# TODO : junco formats for num vars are not according to jj specs - add to backlog!!!
# Question : would updates impact TLG/tests?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depends if we change the default behavior, to discuss

Co-authored-by: David Muñoz Tord <[email protected]>
@munoztd0 munoztd0 changed the title addresses #66 Create Vignette for formatting junco vs. tern, vs. custom: addresses #66 Sep 17, 2025
@munoztd0 munoztd0 closed this Jan 15, 2026
@munoztd0 munoztd0 deleted the vignette_formats branch January 15, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Vignette for formatting junco vs. tern, vs. custom

3 participants