fix: correct nav header alignment and table border gaps (supersedes #449) #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the CSS border-collapse property with value collapse to the main table ruleset. This property merges adjacent table cell borders into a single border, eliminating doubled lines and gaps.
- Changed the .site-nav rule in the _header.scss partial to correct vertical alignment. - Added detailed comments explaining alternative fixes and future tweaks. - Left the suggested removal of the $nav-padding variable in _variables.scss for a follow-up commit to allow review and choice.
The variable was made obsolete by a recent CSS change. It was left untouched in previous commits to allow review and choice.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Align header/nav text & fix table borders
This pull request supersedes #449 with different commit text and updated options and explanations in comments.
Changes made:
.site-navrule in_header.scss.$padding-topvariable that becomes obsolete if suggested title/nav CSS fix is chosen._header.scssCSS for alternative fixes and an additional tweak.border-collapse: collapseon the main table ruleset.Visual Comparison
Pixyll in Action – Original at pixyll.com
Pixyll in Action – Fixed at traven-b.github.io
On the "Pixyll in Action" page, the navigation/header fix now aligns with the README layout. The example tables further down demonstrate the doubled lines and gap fixes.
Notes:
See the comment in
_header.scssfor an additional tweak option to pull up the navigation text on the right side by the tiniest amount, if it seems necessary.The table fix is an obvious, no-mystery one-line addition to
_tables.scss.The header alignment fix is my best guess. January 2019 pixyll.com at archive.org shows a good version, February does not.