This repository has been archived by the owner on Mar 20, 2018. It is now read-only.
Added support for multiple lines of text #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 18, 2015 23:37
…ection * Added contentinsets in headersection to make sure the header text does not overlap the arrow * Adjusted height calculation
* didn't do all the work in one line
|
Looks better now. |
| @@ -128,6 +136,11 @@ -(void)layoutSubviews { | |||
| } | |||
|
|
|||
| -(void)layoutHeader { | |||
|
|
|||
| _sectionStyle.headerHeight = self.headerHeight; | |||
There was a problem hiding this comment.
This breaks the original intention of the property (fixed header height). You should introduce a property (like autosizeHeaders) to toggle between autosizing and fixed height, in order to remain backwards-compatible it should be fixed by default.
|
Any thoughts on this? |
|
Any chance to get this PR merged into the main project? |
|
Thank you... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.