Add rule for "const": generate Java constants#1627
Open
volomas wants to merge 2 commits intojoelittlejohn:masterfrom
Open
Add rule for "const": generate Java constants#1627volomas wants to merge 2 commits intojoelittlejohn:masterfrom
volomas wants to merge 2 commits intojoelittlejohn:masterfrom
Conversation
volomas
force-pushed
the
const_rule
branch
2 times, most recently
from
f992995 to
5a47f07
Compare
Adds rule to generate java constants on "const" properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of now, generator doesn't take into account "const" keyword.
The value of "const" is simply lost during generation.
In this PR, I've added ConstRule that generates java constant:
public static final <Type> <snake_case_var_name> = <value>.This allows to use this value in code like this:
... or just when I need to refer to that constant somewhere in the code.
It doesn't set the generated field value to "const" value, because it would mimic "default", so I wasn't sure if that's a good idea.