Conversation
…ne Linux and one Mac job Co-authored-by: jobovy <1044876+jobovy@users.noreply.github.com>
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #831 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 215 215
Lines 30920 30920
Branches 613 613
=======================================
Hits 30893 30893
Misses 27 27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jobovy
left a comment
There was a problem hiding this comment.
@copilot Actually, the gsl-config.bat file seems to allow gsl-config to be run with the --cflags and --libs arguments, so we can probably run it on Windows as well. Test it in the build_windows.yml workflow in a similar way as for macs.
…P-only step; split Windows GSL env step Co-authored-by: jobovy <1044876+jobovy@users.noreply.github.com>
Done in 4d87e23. The In |
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Co-authored-by: jobovy <1044876+jobovy@users.noreply.github.com>
Co-authored-by: jobovy <1044876+jobovy@users.noreply.github.com>
GSL installed in non-standard prefixes (Homebrew on macOS, conda on Windows) causes
fatal error: 'gsl/gsl_math.h' file not foundwhen users haven't manually setCFLAGS/LDFLAGS.setup.pyAfter the existing
gsl-config --versioncall, invokegsl-config --cflagsandgsl-config --libsand inject discovered paths directly into both C extensions viainclude_dirs,library_dirs, andruntime_library_dirs(rpath on Unix/macOS; empty on Windows).Key details:
shell=Trueon Windows for.batexecutionCFLAGS/LDFLAGS(Unix) orINCLUDE/LIB(Windows)gsl/gsl_math.hfor include dirs,libgsl*orgsl.libfor lib dirs — silently skipping garbage output (e.g. whenCONDA_PREFIXis unset on Windows)CI
build.yml(Linux/macOS):macos-*jobs withtest_energy_jacobi_conservation or from_nameinTEST_FILES(robust to runner version changes)build_windows.yml:gsl-config.batand exportsCONDA_PREFIXso the.batresolves paths correctly);INCLUDE/LIB/LIBPATHis skipped for thetest_actionAngle.pyPython 3.14 job to exercise auto-detection💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.