[WIP] Python3-only reusable thread executor#214
Open
pierreglaser wants to merge 32 commits intojoblib:masterfrom
Open
[WIP] Python3-only reusable thread executor#214pierreglaser wants to merge 32 commits intojoblib:masterfrom
pierreglaser wants to merge 32 commits intojoblib:masterfrom
Conversation
Collaborator
Author
|
Umm, so a bunch of features and bugfixes were added to the |
Collaborator
Author
|
After an IRL talk with @tomMoral, I'm going to not backport all features/bugfixes made to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #189.
This is a Python3-only implementation of a reusable
ThreadPoolExecutor. Making this Python3-only limits the maintainability burden oflokyby not making us backportthreadingutilities forPython2.In particular, this PR implements a new
_ReusableThreadPoolExecutorclass. The appropriate tests from thelokyas well as theconcurrent.futures.ThreadPoolExecutortest suite are ran against it.As a result, most of the changes in this code are test-suite additions-refactoring:
[Theme]ProcessExecutorTestclassesconcurrent.futuresThere is still a bunch of style/renaming to do, but the major part of the work is done.