Skip to content

Fix spark config reading in spark connect #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 7, 2025
Merged

Fix spark config reading in spark connect #63

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9833089
init
WeichenXu123 Apr 7, 2025
df93ee0
nit
WeichenXu123 Apr 7, 2025
a30089f
fix test
WeichenXu123 Apr 7, 2025
80981ea
format
WeichenXu123 Apr 7, 2025
0734bd3
clean
WeichenXu123 Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions joblibspark/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,15 @@ def _create_resource_profile(self,
if self._support_stage_scheduling:
self.using_stage_scheduling = True

default_cpus_per_task = int(self._spark.conf.get("spark.task.cpus", "1"))
default_gpus_per_task = int(self._spark.conf.get("spark.task.resource.gpu.amount", "0"))
if is_spark_connect_mode():
# In Spark Connect mode, we can't read Spark cluster configures.
default_cpus_per_task = 1
default_gpus_per_task = 0
else:
default_cpus_per_task = int(self._spark.conf.get("spark.task.cpus", "1"))
default_gpus_per_task = int(
self._spark.conf.get("spark.task.resource.gpu.amount", "0")
)
num_cpus_per_spark_task = num_cpus_per_spark_task or default_cpus_per_task
num_gpus_per_spark_task = num_gpus_per_spark_task or default_gpus_per_task

Expand Down
Loading