feat: reimplement request-stream with async Stream trait#20
Merged
jmjoy merged 2 commits intojmjoy:masterfrom Jul 15, 2025
Merged
feat: reimplement request-stream with async Stream trait#20jmjoy merged 2 commits intojmjoy:masterfrom
jmjoy merged 2 commits intojmjoy:masterfrom
Conversation
imgurbot12
force-pushed
the
feat/stream
branch
2 times, most recently
from
4fed908 to
79a552e
Compare
imgurbot12
changed the title
imgurbot12
force-pushed
the
feat/stream
branch
2 times, most recently
from
7dca710 to
a2dc34f
Compare
Contributor
Author
|
Sorry about all the force pushes. I've never used verified signatures on commits before and was trying to figure it out lol. I finally managed it :) |
Owner
|
Please merge the master branch; I just fixed the CI issue. |
Contributor
Author
|
Just rebased from master, sorry for delay. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! Love the library, however I ran into some issues passing the buffered output to an actix-web service primarily because the
ResponseStreamobject did not implement the standard futures asyncStreamtrait.I saw that the implementation was delayed due to some previous issue but I thought I'd take a crack at an implementation and this one seems to work and pass all the existing tests as well as for my actix-web service's needs.
Hopefully this is of use to you and others using the library :)
Technical Details
Re-implements
ResponseStreamwithStreamtrait implementation.Now uses
StreamExtfor.nextfunction recommended in the existing documentation.