Add ability to custom insertion in Params#18
Merged
jmjoy merged 5 commits intojmjoy:masterfrom Jul 15, 2025
Merged
Conversation
This commit introduces a custom method for inserting parameters into PHP-FPM requests. This was necessary because the general methods for parameter insertion might not include required parameters, such as HTTP_HOST, which is crucial for WordPress to function properly. The custom approach ensures that all necessary parameters are provided for correct operation.
Owner
|
But |
Contributor
Author
|
Oh, sorry for my carelessness. |
Owner
|
What's wrong with mutable variables? |
jmjoy
reviewed
Jul 15, 2025
jmjoy
approved these changes
Jul 15, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a custom method for inserting parameters into PHP-FPM requests. This was necessary because the general methods for parameter insertion might not include required parameters, such as HTTP_HOST, which is crucial for WordPress to function properly. The custom approach ensures that all necessary parameters are provided for correct operation.