Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newbranch #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Newbranch #1

wants to merge 2 commits into from

Conversation

jm355
Copy link
Owner

@jm355 jm355 commented Jan 27, 2019

merging newbranch into master for assignment

jm355
jm355 commented Jan 27, 2019
View reviewed changes
Copy link
Owner Author

@jm355 jm355 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

I couldn't approve it because I'm the author. the assignment says to select approve but when I try to it says "Pull request authors can't approve their own pull request" so I'll just leave it as a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jm355