Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CR and CRLF newlines #13

Merged
merged 1 commit into from
Sep 1, 2014
Merged

Conversation

koraktor
Copy link
Contributor

This allows to parse TOML files saved with CR (Mac) or CRLF (DOS) newlines.

@88Alex
Copy link

88Alex commented Jul 5, 2013

'\n' evaluates to CRLF on Windows and CR on Unix systems anyway, so there's no need.

@koraktor
Copy link
Contributor Author

koraktor commented Jul 5, 2013

There's a need because you can't parse files with CRLF on UNIX systems.

@lessless
Copy link

@koraktor @dirk
I hope this can fix #24

@parkr
Copy link
Collaborator

parkr commented Feb 17, 2014

This can't be merged at the moment – would you mind redoing your current PR off the master branch, whether that means spiking out a new PR or rebasing the current stuff? Thanks!

@koraktor
Copy link
Contributor Author

Done. 😏

@parkr
Copy link
Collaborator

parkr commented Aug 31, 2014

Hey, what are your thoughts on this? Still interested in seeing this being merged?

@koraktor
Copy link
Contributor Author

koraktor commented Sep 1, 2014

I no longer use TOML in any of my projects, so I'm not personally interested in this issue.

But isn't that problem simple and clear enough to just merge that patch?

@parkr
Copy link
Collaborator

parkr commented Sep 1, 2014

Yep, thanks!

parkr added a commit that referenced this pull request Sep 1, 2014
Add support for CR and CRLF newlines
@parkr parkr merged commit d39648b into jm:master Sep 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants