Fixed: split plane now correctly chooses the dimensions with the larg…

…est span Fixes #33
jlblancoc · Dec 20, 2016 · f2efec0 · f2efec0
1 parent 206d65a
commit f2efec0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.txt b/CHANGELOG.txt
@@ -1,3 +1,7 @@
+nanoflann 1.2.3: Released Dec 20, 2016
+  * Fixed: split plane now correctly chooses the dimensions with the largest span. 
+    Should lead to more optimal trees.
+
 nanoflann 1.2.2: Released Nov 10, 2016
   * knnSearch() now also returns the number of valid points found.
 

diff --git a/include/nanoflann.hpp b/include/nanoflann.hpp
@@ -70,7 +70,7 @@ namespace nanoflann
   *  @{ */
 
   	/** Library version: 0xMmP (M=Major,m=minor,P=patch) */
-	#define NANOFLANN_VERSION 0x122
+	#define NANOFLANN_VERSION 0x123
 
 	/** @addtogroup result_sets_grp Result set classes
 	  *  @{ */
@@ -1116,7 +1116,7 @@ namespace nanoflann
 				ElementType span = bbox[i].high-bbox[i].low;
 				if (span>(1-EPS)*max_span) {
 					ElementType min_elem, max_elem;
-					computeMinMax(ind, count, cutfeat, min_elem, max_elem);
+					computeMinMax(ind, count, i, min_elem, max_elem);
 					ElementType spread = max_elem-min_elem;;
 					if (spread>max_spread) {
 						cutfeat = i;